Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@uilianries
Copy link
Contributor

@uilianries uilianries commented Jun 3, 2025

The original contribution guide only recomends using virtual environment, but when running pytest, a few tests fail due missing virtual environment:

tests/integration/test_requirements.py FFF..                                                                                                                                                                                                  [ 51%]

....

 def test_install_editable_with_requirements_fail():
        c = TestClient()
        c.run("new mynamespace:mycommand")
        c.save({"requirements.txt": "tomato_this_wont_exist"})
        c.run("install . -e -v", assert_error=True)
        # TODO: Decide if better to remove these commands, disable or what
>       assert "ERROR: No matching distribution found for tomato_this_wont_exist" in c.out
E       AssertionError: assert 'ERROR: No matching distribution found for tomato_this_wont_exist' in 'Error: You must be within a virtual environment to install requirements or use \nthe --create-env argument.\n'
E        +  where 'Error: You must be within a virtual environment to install requirements or use \nthe --create-env argument.\n' = <tests.utils.tools.TestClient object at 0x1077af790>.out


This PR changes from a suggestion to mandatory the virtual environment need.

CONTRIBUTING.md Outdated
Comment on lines 7 to 8
mandatory to **create a virtual environment** to ensure that all tests will be able to
run without any restriction.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add that is mandatory in the Running the Tests section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, commit 5cd4a79

@czoido czoido changed the title Tome tests require isolated environment always Add note about tome tests requiring a virtual environment to pass Jun 3, 2025
@czoido czoido merged commit 983f014 into jfrog:main Jun 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants