[UX] Provide better error when using bad install #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
davidsanfal
requested changes
Aug 29, 2025
Collaborator
|
Looks good! |
Co-authored-by: David Sánchez Falero <[email protected]>
Co-authored-by: David Sánchez Falero <[email protected]>
Contributor
Author
|
@davidsanfal Thank you for your review. Your suggestions are now merged into the code. |
Collaborator
|
Looks good! |
Contributor
Author
I gonna check it! |
Signed-off-by: Uilian Ries <[email protected]>
Contributor
Author
|
@czoido @davidsanfal I made a small change for uninstall message as well. Previously, it was:
Now, when trying to uninstall a file instead of a directory, it will be:
|
czoido
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a script using
tome install -ebut instead of pointing to the folder where those scripts are, when pointing to a specific script, the command fails with an not expected scenario:tome install -e ~/Development/tome/tome-commands/ansible/list_inventories.py Error: Traceback (most recent call last): File "/home/uilian/Development/tome/tomescripts/tome/cli.py", line 405, in main cli.run(args) File "/home/uilian/Development/tome/tomescripts/tome/cli.py", line 337, in run command.run(self._tome_api, args[0][1:]) File "/home/uilian/Development/tome/tomescripts/tome/command.py", line 177, in run info = self._method(tome_api, self.parser, *args) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/uilian/Development/tome/tomescripts/tome/commands/install.py", line 67, in install result = tome_api.install.install_editable(source, args.force_requirements, args.create_env) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/uilian/Development/tome/tomescripts/tome/api/subapi/install.py", line 15, in install_editable return install_editable(source, self.tome_api.cache_folder, force_requirements, create_env) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/uilian/Development/tome/tomescripts/tome/internal/installer.py", line 236, in install_editable if not _has_valid_commands(source.uri): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/uilian/Development/tome/tomescripts/tome/internal/installer.py", line 169, in _has_valid_commands for subdir_name in os.listdir(directory): ^^^^^^^^^^^^^^^^^^^^^ NotADirectoryError: [Errno 20] Not a directory: '/home/uilian/Development/tome/tome-commands/ansible/list_inventories.py'Using the following PR content, the output will be: