Refactor resolveAllDNS Concurrency Pattern #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change refactors the
resolveAllDNSfunction to simplify its concurrency handling.Changes:
resolveAllDNSthat used a select loop to interleave sending work (workCh) and receiving results (dnsResponseCh).workCh2/dnsResponseCh2, now using the standardworkCh/dnsResponseChnames) which follows the simpler and generally more robust "send all work -> close work channel -> receive all results" approach.Reasoning:
No functional changes are expected as a result of this refactoring; it purely streamlines the implementation.
Other small changes