Add ProtoVsJsonSizeTests to compare Protobuf and JSON payload sizes #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jgador
commented
Nov 8, 2025
- Implemented a test to verify that Protobuf encoding produces a smaller payload than JSON.
- Created a sample ExportLogsServiceRequest for testing purposes.
- Added output logging for serialized JSON and Protobuf payloads, including their byte lengths.
- Implemented a test to verify that Protobuf encoding produces a smaller payload than JSON. - Created a sample ExportLogsServiceRequest for testing purposes. - Added output logging for serialized JSON and Protobuf payloads, including their byte lengths.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test to compare Protobuf and JSON serialization sizes for OTLP log data, and includes a PowerPoint presentation file. The test demonstrates that Protobuf encoding produces smaller payloads than JSON for OpenTelemetry log records.
Key Changes:
- Added a new test class
ProtoVsJsonSizeTeststo verify Protobuf's size efficiency over JSON - Added Google.Protobuf and Grpc.Tools package references to the test project
- Configured Protobuf compilation in the test project for .proto files
- Added a PowerPoint presentation file
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Loggle.Tests/ProtoVsJsonSizeTests.cs | New test class comparing Protobuf vs JSON payload sizes |
| test/Loggle.Tests/Loggle.Tests.csproj | Added Google.Protobuf and Grpc.Tools dependencies, configured Protobuf compilation |
| Loggle-demo-deck.pptx | Added PowerPoint presentation file (binary) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+37
to
+38
| <Protobuf Include="$(RepoRoot)\src\Shared\Proto\**\*.proto" Link="Proto\%(RecursiveDir)%(Filename)%(Extension)" Access="public"> | ||
| <ProtoRoot>$(RepoRoot)\src\Shared\Proto</ProtoRoot> |
There was a problem hiding this comment.
The Protobuf path uses backslashes which may cause issues on non-Windows platforms. Consider using forward slashes or Path.DirectorySeparatorChar for cross-platform compatibility. For example: $(RepoRoot)/src/Shared/Proto/**/*.proto
Suggested change
| <Protobuf Include="$(RepoRoot)\src\Shared\Proto\**\*.proto" Link="Proto\%(RecursiveDir)%(Filename)%(Extension)" Access="public"> | |
| <ProtoRoot>$(RepoRoot)\src\Shared\Proto</ProtoRoot> | |
| <Protobuf Include="$(RepoRoot)/src/Shared/Proto/**/*.proto" Link="Proto\%(RecursiveDir)%(Filename)%(Extension)" Access="public"> | |
| <ProtoRoot>$(RepoRoot)/src/Shared/Proto</ProtoRoot> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.