FB2 writer: use genre metadata field #5478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Maybe you could rebase from master so the CI can run? |
5f7c119 to
3805dd0
Compare
Rebased. |
jgm
reviewed
May 3, 2019
src/Text/Pandoc/Writers/FB2.hs
Outdated
| description :: PandocMonad m => Meta -> FBM m Content | ||
| description meta' = do | ||
| let genre = el "genre" "unrecognised" | ||
| let genre = case lookupMeta "genre" meta' of |
There was a problem hiding this comment.
simplify this by using lookupMetaString from T.P.Writers.Shared.
Otherwise looks good!
3805dd0 to
ccf4bdc
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation FB2 genre tag contains hardcoded value "unrecognised".
This PR makes use of genre field specified in metadata.
@jgm, could you review this please?