-
-
Notifications
You must be signed in to change notification settings - Fork 269
Added fixes for searching and various things #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- better typesense 0.24.1 support - exhaustive search disabled by default - central place for the MAX_RESULTS_PER_PAGE option - added class for getting searchable attributes of models in typesense
78ba97f to
eed1a33
Compare
|
Searching
|
Do you think we should add these to |
Only if we want to fully support the tweaking of it for not so hardcore users. |
|
LGTM |
max_results_per_page()helper function as part of this fix./v4/schedules/<dayFilter>request validator.?q=searchterm&order_by=scorewould not order byscore, rather by the default sort order.Exhaustive search disabled means that typesense will eat less system resources, but the number of hits will decrease, but the quality of relevance won't be affected.
I think with earlier versions of typesense we used exhaustive search to have enough hits. However the latest version already returns enough hits with exhaustive search turned off for most of the use cases. Only the
drop_tokens_thresholdandtypo_tokens_thresholdneeds to be tweaked, and we can get good enough results I think.Might fixes these issues: