Improves sentry integration and order of exceptions #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves exception handling and reporting. Right now it's exhausting all sentry transactions (5k in the free tier) within the first week or so. This is because TimeoutException and other unnecessary exceptions are being sent to it as well.
Exception to check in order
if ($e instanceof Exception && $e->getMessage() === "Undefined index: url") {a. MAL returns blank pages for some reason sometimes. And this is the generated error
I don't think that's possible. But I am working on integrating Sentry with GitHub and this repo so sentry should automatically create issues for us if it hits a parser exception.