Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes + Updates Seasons API #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 25, 2022
Merged

Fixes + Updates Seasons API #287

merged 14 commits into from
Nov 25, 2022

Conversation

@irfan-dahir
Copy link
Contributor

@irfan-dahir irfan-dahir commented Oct 26, 2022 •
edited
Loading

  • Fixes /seasons/* not returning other entry types
  • Adds type query filter to /seasons/*

Resolves #217

Don't think we need to add any more filter types here. If the user wants to create an advanced seasonal query, they can use the search API instead.

e.g /v4/seasons/2022/fall?type=movie corresponds directly to
/v4/anime?start_date=2022-10-1&end_date=2022-12-31&type=movie

⚠Note: Need to run php artisan swagger-lume:generate once this PR is updated with the latest changes in master from #285

@irfan-dahir irfan-dahir requested a review from pushrbx October 26, 2022 00:46
@irfan-dahir irfan-dahir self-assigned this Oct 26, 2022
@irfan-dahir
Copy link
Contributor Author

irfan-dahir commented Oct 26, 2022 •
edited
Loading

Since this is the only filter available here, I'm thinking of renaming type to filter. This would be the same pattern that is followed in other requests like Top. e.g /top/anime?filter=airing or schedule?filter=monday - as it corresponds to the tabs provided on the MAL page. 🤔

That would make more sense IMO.

pushrbx
pushrbx requested changes Oct 27, 2022
View reviewed changes
@AniLeo
Copy link

AniLeo commented Oct 29, 2022

Thanks for the fix, will keep an eye for the merge

@irfan-dahir irfan-dahir requested a review from pushrbx October 30, 2022 06:19
@pushrbx pushrbx modified the milestones: v4.0.0-rc.6, REST 4.0 Oct 30, 2022
@Green-Cat
Copy link

Any chance to have this merged?

@irfan-dahir irfan-dahir requested a review from a team as a code owner November 19, 2022 16:03
@irfan-dahir
Copy link
Contributor Author

@pushrbx g2g?

@pushrbx
Copy link
Collaborator

pushrbx commented Nov 20, 2022 •
edited
Loading

@pushrbx g2g?

I'll try to review it again and test it in the coming week. 👍 (Nov 21-25)

pushrbx
pushrbx requested changes Nov 24, 2022
View reviewed changes
@pushrbx
Copy link
Collaborator

pushrbx commented Nov 24, 2022

⚠Note: Need to run php artisan swagger-lume:generate once this PR is updated with the latest changes in master

This can be part of a github action too

@irfan-dahir irfan-dahir requested a review from pushrbx November 25, 2022 05:13
pushrbx
pushrbx approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@pushrbx pushrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charlie Day Thumb

@irfan-dahir irfan-dahir merged commit 2d93956 into master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pushrbx pushrbx pushrbx approved these changes

Assignees

@irfan-dahir irfan-dahir

Labels

feature

Projects

None yet

Milestone

REST 4.0

Development

Successfully merging this pull request may close these issues.

v4/seasons: Bug causes only some entries to be listed

4 participants

@irfan-dahir @AniLeo @Green-Cat @pushrbx