fix case-insensitivity #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit changes the default behavior to be case-insensitive, which breaks tests and compatibility, this fixes that. I've duplicated the tests because it was a bit difficult to do it in any other way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 61dc501 changed Copier's default setting to be case-insensitive, causing some tests to fail. I've fixed this by making Copier case-sensitive again.
I copied the "primary set of tests" to test the new case-insensitive functionality, this was simpler than introducing generics and breaking go 1.13 compatibility, it should be easy to remove the unneccessary tests (if any).
To see the change in action, checkout and do
go test ./...