Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(cli): autocomplete #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlespiau merged 4 commits into from
Mar 15, 2019
Merged

feat(cli): autocomplete #146

dlespiau merged 4 commits into from
Mar 15, 2019

Conversation

@tombrk
Copy link
Contributor

@tombrk tombrk commented Mar 14, 2019

This PR adds autocompletion support for bash and zsh.

Added Functionality

  • Subcommand completion for both shells
  • Filename completion for jk run -f in bash (yaml, yml, json). Cobra does not seem to support this in zsh at the moment.

Generating completions

  • bash: source <(jk completion)
  • zsh: jk completion zsh > _jk, then move _jk into $fpath and run compinit.

Closes #113

tombrk added 2 commits March 14, 2019 22:00
@tombrk
feat(cli): completion command
74f36d6 
Adds completion command for generating full shell autocompletions:
- bash: Fully supported
- zsh: Only minimal support, related to cobra
@tombrk
feat(cli): run cmd paramsSourceFile flag filename completion
c4cd4e9 
Completes only yaml and json
dlespiau
dlespiau approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@dlespiau dlespiau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! With two little changes this looks good to me!

  • Our CI linter tests the files are formatted with the -s gofmt option
  • Adding some instructions for zsh in the long help text

tombrk added 2 commits March 15, 2019 14:07
@tombrk
doc(cli): zsh completion
7886232
@tombrk
fix(cli): run.go formatting
7f17f06 
Fixes the formatting to accord to `gofmt -s`
@dlespiau
Copy link
Member

dlespiau commented Mar 15, 2019

Thanks a lot for this contribution! Happily merging! :)

@dlespiau dlespiau merged commit b1f82db into jkcfg:master Mar 15, 2019
@tombrk tombrk deleted the cli-complete branch March 15, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlespiau dlespiau dlespiau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tombrk @dlespiau