Use resolved path when resolving relative imports #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm going to squash this when I merge. One thing I have noticed, that I ought to test and fix, is that the "candidates" list can be inconsistent -- with repeated entries in particular. I was not too careful about getting it exactly right when I implemented the module resolution. |
Member
|
Ah yes, I noticed that too and thought we could have pass deduplicating entries. |
Member
Author
My feeling is that a correct resolution procedure would not consider each path more than once. I suppose different importers might do so (but you'd kind of hope they wouldn't overlap?) |
Prior to npm module resolution, the specifier for a module and the file path had a direct relationship, and it was a reasonable approximation to make base/specifier the new base for recursive imports. However, npm modules can be resolved to paths that don't correspond closely with the specifier; so, explicitly return the filesystem path from `Import` and use that to resolve recursive imports.
6866f6e to
8074582
Compare
To make import failures a little more transparent, give each import candidate an annotation saying which rule was being applied. In the case of the NPM importer, these can get quite complicated ..
.. specifically, eslint rules pertaining to module imports, since that's what's under test.
d2867a6 to
421b713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to npm module resolution, the specifier for a module and the
file path had a direct relationship, and it was a reasonable
approximation to make base/specifier the new base for recursive
imports.
However, npm modules can be resolved to paths that don't correspond
closely with the specifier; so, explicitly return the filesystem path
from
Importand use that to resolve recursive imports.(Another way to do this would be to take the top path from the candidates list, and assume the contract that it must be the successful path (if bytes is not empty).)