Additional Windows Fixes for Dev running and for importing modules in a server #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev mode. 2) Fixing this for allowing server.py files to include module imports. Before they weren't resolving properly.
… twice, once to find it, and once to execute it, but unix will only call once.
jlowin
approved these changes
Dec 3, 2024
jordicore
pushed a commit
to jordicore/fastmcp
that referenced
this pull request
Jul 2, 2025
Additional Windows Fixes for Dev running and for importing modules in a server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
The dev action in cli.py could not find node or npx in the running processes due to the way they are called and managed. Added additional code for windows that checks for node/npx properly. This required an OS aware test change. Windows calls for npx subprocess twice, and unix only once. The test was only expecting once in all occasions.
If a MCP server included modules, the cli would fail to build them because it wouldn't do it from the root of the mcp server being built. Added short code to add parent directory to path if not already there.