Skip unmatching optional pattern groups #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest GS1 Application Identifier dataset, there are four AIs with optional pattern groups. When the value matches everything but the optional pattern group, the group's value becomes `None`. This caused Biip to crashed when we tried building a string of the characters matching the pattern. Fixes #295
91cbf99 to
7a8c9a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest GS1 Application Identifier dataset, there are four AIs
with optional pattern groups. When the value matches everything but the
optional pattern group, the group's value becomes
None. This causedBiip to crash when we tried building a string of the characters
matching the pattern.
Fixes #295