Refactored Value::Ranges coalesce(). #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Review: https://reviews.apache.org/r/38158
b0c4448 to
2a08890
Compare
joerg84
pushed a commit
that referenced
this pull request
Apr 19, 2016
In this patch, we did the following changes: 1. Duplicate executable file 'mesos-slave' with 'mesos-agent' 2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy' to use term 'agent' instead of term 'slave' 3. Change the content of ths scripts to use term 'agent' instead of term 'slave' 4. Duplicate the renamed scripts renamed in #2 during the configure and make process, the duplicated scripts still use term 'slave' in their names. Please note that a re-bootstrap is required once this patch has been applied. Otherwise, configure will break because of the missing mesos-slave-*.sh scripts. Review: https://reviews.apache.org/r/45806/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051).
Review: https://reviews.apache.org/r/38158