Min values for number ranges #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e -* as minvalues also parseListOfLong & parseListOfDouble now spcecify their types in erros instead of "string"
…er & parseListOfDouble & parseListOfLong
…ving double checking. Added comments of 'weird' behavior.
Member
|
@jolie/core Can I get a double check on using |
Member
|
In my opinion this looks good, since we a) add a new functionality which makes sense, b) do some refactoring to reduce code duplication. |
Member
|
Sorry I did not get the meaning of token '-*' in intervals. Could you provide some examples? |
Member
|
Basically you can now write things like `ranges( [-*,10] )` to express an
integer from MIN_INT (which is negative) to 10. We cannot currently express
MIN_INT in ranges.
What I'm asking is: is this a good syntax for expressing MIN_INT?
…On Mon, 23 Sept 2024, 16:59 Claudio Guidi, ***@***.***> wrote:
Sorry I did not get the meaning of token '-*' in intervals.
Could you provide some examples?
—
Reply to this email directly, view it on GitHub
<#524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAP3DSNW2UZ64CR4S4ZMJS3ZYAUG3AVCNFSM6AAAAABOUVGRRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGU2DQMRSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Member
|
But the idea is that, when there is '-*' there is no lower limit, right? |
Member
|
Right (well, no limit on top of what the type supports, like int can't go
lower than MIN_INT)
…On Mon, 23 Sept 2024, 17:05 Claudio Guidi, ***@***.***> wrote:
But the idea is that, when there is '-*' there is no lower limit, right?
—
Reply to this email directly, view it on GitHub
<#524 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAP3DSJE2WA653IPC6BOL5DZYAU3VAVCNFSM6AAAAABOUVGRRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGU3TCNBUGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility for '-*' in ranges of type refinements, and did some refactoring and commenting of peculiarities.