Fix/mustache recursive templates #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontesi
reviewed
Nov 13, 2024
| } | ||
|
|
||
| embed Mustache as mustache | ||
| embed Console as Console |
Member
There was a problem hiding this comment.
You import and embed console but it's not used. Remove?
| data:undefined ///< The data for the template | ||
| dir?:string ///< The directory in which to look for other templates (for partials) | ||
| recursionLimit?: int ///< Maximum limit for recursive calls in partials. Default is 100 | ||
| partialsRecursionLimit?: int ///< Maximum limit for recursive calls specific for partials. Dafult is 10 |
Member
There was a problem hiding this comment.
What is exactly the difference between recursionLimit and partialsRecursionLimit? Is there another way to do recursion than using partials?
Member
Author
There was a problem hiding this comment.
recursionLimit is the general count of recursive calls. partialsRecursionLimit is the limit in recurisve calls specifically for each partials. In case you have more recursive dependency among partials, you need both for determine the depth of the tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.