-
Notifications
You must be signed in to change notification settings - Fork 55
fix JSON converter finds correct subtype if subtypes in TypeChoice has same name #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fmontesi
merged 6 commits into
jolie:master
from
Niels-Erik:fix-JSON-converter-find-correct-subtype
Nov 24, 2024
Merged
fix JSON converter finds correct subtype if subtypes in TypeChoice has same name #539
fmontesi
merged 6 commits into
jolie:master
from
Niels-Erik:fix-JSON-converter-find-correct-subtype
Nov 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which also corresponds to the Value valueToJsonString in JsUtils.java now uses the new method to find the correct subtype
Member
|
Could you add a test |
Member
|
Agreed, a test would be nice. Otherwise the PR looks good! :) |
Contributor
Author
|
Thank you, I'll add a test. |
Contributor
Author
mwallnoefer
pushed a commit
that referenced
this pull request
Nov 25, 2024
…ct-subtype fix JSON converter finds correct subtype if subtypes in TypeChoice has same name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added findSubType that takes a String and a Value, and finds the Type which also corresponds to the Value
valueToJsonString in JsUtils.java now uses the new method to find the correct subtype
This is to fix the issue reported in discord:
sundedrengen — 10/29/2024 2:02 AM
We are pretty sure we found a bug in the way Jolie generates json reponses in the following circumstance (tested on jolie commit 3b8c752):
Not sure if it is done in the correct way.