Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the ParsingContext of Services via a new wrapper for generating ParsingContexts #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kas0079 wants to merge 5 commits into from
Closed

Fix the ParsingContext of Services via a new wrapper for generating ParsingContexts #581

kas0079 wants to merge 5 commits into from

Conversation

@kas0079
Copy link
Contributor

@kas0079 kas0079 commented Feb 7, 2025

Adds a wrapper function parseInternals to make it easier to generate correct ParsingContexts when parsing.

Also refactors parseService to generate its ParsingContext using that method, fixing its previously incorrect parsingContext

@Niels-Erik Niels-Erik mentioned this pull request Feb 12, 2025
Open
@mwallnoefer mwallnoefer requested a review from fmontesi March 15, 2025 11:36
@kas0079 kas0079 mentioned this pull request Mar 27, 2025
Merged
@mwallnoefer
Copy link
Member

mwallnoefer commented Apr 26, 2025

@kas0079 Should PR #605 replace this one?

@kas0079
Copy link
Contributor Author

kas0079 commented Apr 26, 2025

@kas0079 Should PR #605 replace this one?

Yes, while #605 is technically wraps a different method, there is a lot of overlap and it fixes some deeper problems with the implementation of the wrapper that this PR doesn't.
So maybe it is better to close this one, then I can remake it in a simpler form once #605 is merged.

@kas0079 kas0079 closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmontesi fmontesi Awaiting requested review from fmontesi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kas0079 @mwallnoefer