Fix extend typelink linked type is null #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one with embed as, and one with just embed (this one fails)
getOrBuildExtendedType now calls resolveTypeLinks after each time it calls buildType
… extend, so that it catches more.
mwallnoefer
reviewed
Jun 5, 2025
mwallnoefer
reviewed
Jun 5, 2025
mwallnoefer
reviewed
Jun 5, 2025
kicito
reviewed
Jun 6, 2025
kicito
approved these changes
Jun 10, 2025
Member
|
Thank you all for the discussion, this looks pretty good! :) |
Niels-Erik
added a commit
to Niels-Erik/jolie
that referenced
this pull request
Sep 2, 2025
* added tests for extending with a type from another file: one with embed as, and one with just embed (this one fails) * added some null handling in Type when calling extend, properly to be reworked * quickfix for TypeLink extend bug getOrBuildExtendedType now calls resolveTypeLinks after each time it calls buildType * changed palcement of call to resolveTypeLinks to right before calling extend, so that it catches more. * Used String.format instead of string concatenation * applied refactoring as per github review * added assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug exists in using a type from another file in an extender.
I created two tests that tests for this when using embed with as, and using embed without as.
The bug only seems to happen when embedding without as.
What happens is: that the Type Link is build, but the link is not added. This also gives a null exception when trying to throw new UnsupportedOperationException, so some Null checking has been put in.
I have also found the source that has the problem and applied a quickfix.
This bug has been introduced in Jolie 1.13, and did not exist in Jolie 1.12.