fix diff blame navigation #1338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About the failing tests... can either remove the existing places where diff prefixes are handled, or try to centralize them and cover all cases. e.g. https://github.com/jonas/tig/blob/tig-2.5.10/src/diff.c#L745 (there are others, searching for "prefix" on the log) the places that have that code would still fail if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does not "support" git options such as
noprefix,mnemonicPrefix, etc. As in, they will not have the desired effect on diff view, like #1337 was trying to implement.It just overrides them with the
--default-prefixcommand line when getting the diffs, so blame navigation (e.g. pressing "b" in a diff) works.fix #1336