simulated keystrokes in test suite #736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8d83c7 to
749c3c4
Compare
749c3c4 to
03d93df
Compare
8b8091c to
8dab39b
Compare
and preserve a connection between input window (status_win) and tty. Ncurses fails to initialize in the usual way unless the args to newterm are both ttys.
and generalize for any other executable requirements
needed for keystroke-stuffer
since it works by setting an environment variable. Logically perhaps all items should be in the subshell.
needed for valgrind to work with simulated keystrokes
* keystrokes() * test_case -keystrokes * TEST_OPTS='trace_keys' * docs
simulated keys can work around the inability of scripts to run other scripts
8dab39b to
a087e81
Compare
|
Now that tig is the process-group leader this PR is more focused and can be evaluated on its own. I suspect that you won't like the added complexity and the python requirement (though keystroke test are skipped without python.) But it was fun to do in any case. The motivation was to provide test coverage to some hidden corners that libtest scripts could not reach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Further documented in
test/README.adoctest/API.adoc.This is in reasonably functional form but is a WIP in part because it will merge conflict with several other outstanding PRs.This is in functional form and merge conflicts have been resolved.Another interesting approach to simulating input is driving tig inside of tmux as in
this has the advantage that the screen-capture action can be done by tmux. Though leveraging that would likely mean changing all existing tests.