-
Notifications
You must be signed in to change notification settings - Fork 1
[103] Configure linting with ruff
#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring to appease the linter would make the code less readable.
The function is structured according to `attrs` documentation. Cf. https://www.attrs.org/en/stable/init.html#callables
The function name is reasonable in context.
Parameterization is as intended.
The name is reasonable in context.
|
Apparently the double-dash ( |
|
I should also check out these default scripts for the hatch fmt:lint-check |
|
In fact, I can just pass args to the hatch fmt -l # just run the linter
hatch fmt --check # just do a check, don't fix anything |
It is automatically generated during build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR closes #103.