fix: char class casefold for certain chars #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is the |
Member
|
@lopex You mean we should be using our equivalent macros to check the result? |
Member
|
We have a need to release joni this week for a JRuby release next week. I'm going to bump this to a future release. It's simple enough to kick out another release when these PRs are ready. |
Member
|
After doing some experimentation this fix appeared to be valid and "good enough", so we merged it and released joni 2.2.4. I have filed an issue with CRuby since they still exhibit the same problem, and they have a similar fix in the past week we may want to mimic: https://bugs.ruby-lang.org/issues/21162 |
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 3, 2025
jcodings 1.0.62: * update unicode to 15.0 (jruby/jcodings#66) joni 2.2.4: * update jcodings to 1.0.62 * fix: char class casefold for certain chars (jruby/joni#85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of PR #20