Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Oct 22, 2015

No description provided.

@pitr-ch pitr-ch self-assigned this Oct 22, 2015
@pitr-ch pitr-ch added this to the truffe milestone Oct 22, 2015
@pitr-ch pitr-ch force-pushed the master branch 3 times, most recently from fca7c7f to be4a64e Compare October 22, 2015 16:41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English is weird. You really want to say "Windows is not" here because it's a singular item referring to the name of the operating system.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is, no?

@nirvdrum
Copy link
Contributor

Looks good.

@mkristian
Copy link
Member

looks good for me as well. but I really would like to hear some comment from @headius and @enebo about adding this to ./lib/ruby/stdlib

@pitr-ch pitr-ch force-pushed the master branch 2 times, most recently from 55681ec to dad7f08 Compare October 23, 2015 12:15
@mkristian mkristian modified the milestones: JRuby 9.0.5.0, truffe Oct 23, 2015
@pitr-ch pitr-ch force-pushed the master branch 2 times, most recently from be7eac4 to 90bf1a0 Compare October 30, 2015 15:18
@pitr-ch
Copy link
Member Author

pitr-ch commented Oct 30, 2015

@enebo @headius: is this too invasive, or can it be merged?

@enebo
Copy link
Member

enebo commented Nov 5, 2015

@pitr-ch is there any reason this cannot be in lib/ruby/truffle? stdlib is mostly for files which are in MRI's stdlib. I think we have some variants like jossl (although I think this is a mistake) but mostly those variants are working around differences between MRI and JRuby.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 8, 2015

@enebo This tool is suppose to be loaded in JRuby it can prepare environment to run files with gems in JRuby+Truffle and then run files in the prepared environment. The tool always runs in JRuby it computes required options and then it executes JRuby+Truffle with them. If it is in lib/ruby/truffle it won't be visible to JRuby.

@mkristian
Copy link
Member

@pitr-ch as I understand it, the tool is executes exclusively via the bin/jruby+truffle

so instead of https://github.com/jruby/jruby/pull/3412/files#diff-0e9caaa4ef2b36ca7f4ea6308854ebd7R3
you could use something like

require File.join(JRuby.runtime.instance_config.jruby_home, 'lib/ruby/truffle/jruby+truffle/runner')

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 9, 2015

@mkristian ah thanks for the suggestion. Sounds good, I'll update the PR.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 17, 2015

@mkristian @enebo updated and ready for merge.

@mkristian
Copy link
Member

I think travis does not really run into this change. merging.

mkristian added a commit that referenced this pull request Nov 17, 2015
[Truffle] make j+tr part of the distribution
@mkristian mkristian merged commit 42c4a2c into jruby:master Nov 17, 2015
@mkristian
Copy link
Member

@pitr-ch thanx for all this shifting around a second time

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 18, 2015

No problem at all @mkristian. I was a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants