-
-
Notifications
You must be signed in to change notification settings - Fork 933
[Truffle] make j+tr part of the distribution #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fca7c7f to
be4a64e
Compare
bin/jruby+truffle.bat
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English is weird. You really want to say "Windows is not" here because it's a singular item referring to the name of the operating system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is, no?
|
Looks good. |
55681ec to
dad7f08
Compare
be7eac4 to
90bf1a0
Compare
|
@pitr-ch is there any reason this cannot be in lib/ruby/truffle? stdlib is mostly for files which are in MRI's stdlib. I think we have some variants like jossl (although I think this is a mistake) but mostly those variants are working around differences between MRI and JRuby. |
|
@enebo This tool is suppose to be loaded in JRuby it can prepare environment to run files with gems in JRuby+Truffle and then run files in the prepared environment. The tool always runs in JRuby it computes required options and then it executes JRuby+Truffle with them. If it is in lib/ruby/truffle it won't be visible to JRuby. |
|
@pitr-ch as I understand it, the tool is executes exclusively via the bin/jruby+truffle so instead of https://github.com/jruby/jruby/pull/3412/files#diff-0e9caaa4ef2b36ca7f4ea6308854ebd7R3 |
|
@mkristian ah thanks for the suggestion. Sounds good, I'll update the PR. |
|
@mkristian @enebo updated and ready for merge. |
|
I think travis does not really run into this change. merging. |
[Truffle] make j+tr part of the distribution
|
@pitr-ch thanx for all this shifting around a second time |
|
No problem at all @mkristian. I was a better option. |
No description provided.