Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@headius
Copy link
Member

@headius headius commented Jun 2, 2020

See #6219.

headius added 2 commits June 1, 2020 20:29
This isn't great since we're allowing a null field and checking
for null, but the logic surrounding this has been designed to
lazily create the channel or stream in question. This is likely
due to the use of URLResource and its siblings as generic path/URI
mungers that can clean up and canonicalize/abosolutize even paths
that do not exist. Rather than attempt to isolate that behavior
(which might be a lot more work), I've opted to mimic FileResource
in raising an error along the lazy path when it's clear we don't
have a resource in hand to open.

This fixes jruby#6219.
@headius headius linked an issue Jun 2, 2020 that may be closed by this pull request
@headius headius added this to the JRuby 9.3.0.0 milestone Jun 2, 2020
@headius headius merged commit 90ac20b into jruby:master Jun 3, 2020
@headius headius deleted the missing_urlresource_npe branch June 3, 2020 22:48
@headius headius modified the milestones: JRuby 9.3.0.0, JRuby 9.2.12.0 Jun 16, 2020
@headius
Copy link
Member Author

headius commented Jun 16, 2020

Retargeted to 9.2.12 and cherry-picked into #6285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JRuby thrown NullPointerException on File.open of nonexistent uri

1 participant