Handle modification during delete_if iteration #6393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows adding to the array while iterating. Previously, adding elements while iterating for delete_if would lose existing elements at the end, as they get pushed beyond our memoized size. This behavior is not specified, but we make a best effort to match CRuby behavior. There will be no specs added for this. Fixes jruby#6371
This is unspecified behavior, but because we try to match CRuby I am adding a test to our suite. See jruby#6371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6371 we saw that adding elements to the array while doing a
delete_ifiteration would end up skipping later elements. This was due to us memoizing the initial length of the array; elements added during iteration did not increase this length, so we would stop iterating prematurely.The fix here matches CRuby, acquiring the array's new length for each iteration.
A test is provided in the JRuby suite but not in ruby/spec, due to the unspecified nature of this behavior.