Simplify detached process thread logic #6467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In jruby#6466 we see that the thread from a Process::detach is raising an error when the waitpid fails with an error. This does not appear to match the logic in MRI and also breaks if there is a "raise" hook installed in the system. This change should better match MRI logic for the detach thread and avoid the hook issue reported in jruby#6466. It does not address a separate bug in the trace hook logic when no Ruby frames are available.
|
This PR went against master but the same commit is in 9.2 at 4acd76a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6466 we see that the thread from a Process::detach is raising
an error when the waitpid fails with an error. This does not
appear to match the logic in MRI and also breaks if there is a
"raise" hook installed in the system.
This change should better match MRI logic for the detach thread
and avoid the hook issue reported in #6466. It does not address a
separate bug in the trace hook logic when no Ruby frames are
available.