Expand env-shebang to setup and pristine #6586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup command is used when upgrading RubyGems, and pristine is a clean reinstall. Neither honor the settings for "install" or "update" so we need to force them too. See jruby#4404
|
This is "probably safe" to add into 9.2.16, and fixes an open issue with RubyGems updating (ruby/rubygems#4404) but not one that has been reported by an end user. Users running with the native executable will also not see this issue. Ping @kares and @enebo to consider this. @deivid-rodriguez any reason you can think of this might introduce any risk? |
|
Not that I can think of, no. I'd say it's safe, specially given that you've been shipping this flag by default for |
That is correct. Thanks for the input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup command is used when upgrading RubyGems, and pristine
is a clean reinstall. Neither honor the settings for "install" or
"update" so we need to force them too.
See ruby/rubygems#4404