Use the wide versions of these functions always #7281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two delete functions were modified to be wide in CRuby in response to https://bugs.ruby-lang.org/issues/10820 seven years ago. The query function was mentioned here but not updated to be wide. I am unsure how CRuby is locating the appropriate `A` or `W` function given the bare name, but since we have largely forked this file and always want to use the wide version, this change seems appropriate. Fixes jruby#7106
|
I do not have an answer yet as to why the non-W version of RegQueryInfoKey works on CRuby, nor why they did not explicitly bind it to the wide version in registry.rb, but I believe this is the correct change to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two delete functions were modified to be wide in CRuby in
response to https://bugs.ruby-lang.org/issues/10820 seven years
ago. The query function was mentioned here but not updated to be
wide. I am unsure how CRuby is locating the appropriate
AorWfunction given the bare name, but since we have largely forked
this file and always want to use the wide version, this change
seems appropriate.
Fixes #7106