Prototype of fast block_given? logic using indy #7977
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea here is to avoid pushing a frame for block_given? when it is known to be our core implementation. Instead, we use indy to test the block the current method was called with and return a result directly. When the block_given? is not our core impl, it falls back on a normal indy invocation. This allows us to remove the frame requirement from block_given? callers, and the cost of the block_given? call largely disappears.
Caveats: