Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix remaining copy stream specs #8291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 24, 2024
Merged

Fix remaining copy stream specs #8291

merged 6 commits into from
Jun 24, 2024

Conversation

@headius
Copy link
Member

@headius headius commented Jun 19, 2024

This fixes the following three specs:

1)
IO.copy_stream from an IO to a Tempfile copies the entire IO contents to the IO FAILED
Expected "<long string of A's>" == 
"Line one

Line three
Line four

Line last
<long string of A's>"
to be truthy but was false
/Users/headius/work/jruby/spec/ruby/core/io/copy_stream_spec.rb:52:in `block in <main>'
org/jruby/RubyBasicObject.java:2572:in `instance_exec'
org/jruby/RubyArray.java:4819:in `all?'
org/jruby/RubyArray.java:1945:in `each'
org/jruby/RubyArray.java:1945:in `each'
org/jruby/RubyArray.java:1945:in `each'
/Users/headius/work/jruby/spec/ruby/core/io/copy_stream_spec.rb:100:in `<main>'
org/jruby/RubyKernel.java:1205:in `load'
org/jruby/RubyBasicObject.java:2572:in `instance_exec'
org/jruby/RubyArray.java:1945:in `each'
                                                                                             
2)
IO.copy_stream from an IO to a Tempfile starts writing at the destination IO's current position FAILED
Expected 
"Line one

Line three
Line four

Line last
" == 
"prelude Line one

Line three
Line four

Line last
"
to be truthy but was false
/Users/headius/work/jruby/spec/ruby/core/io/copy_stream_spec.rb:63:in `block in <main>'
org/jruby/RubyBasicObject.java:2572:in `instance_exec'
org/jruby/RubyArray.java:4819:in `all?'
org/jruby/RubyArray.java:1945:in `each'
org/jruby/RubyArray.java:1945:in `each'
org/jruby/RubyArray.java:1945:in `each'
/Users/headius/work/jruby/spec/ruby/core/io/copy_stream_spec.rb:100:in `<main>'
org/jruby/RubyKernel.java:1205:in `load'
org/jruby/RubyBasicObject.java:2572:in `instance_exec'
org/jruby/RubyArray.java:1945:in `each'
                                                                                             
3)
IO.copy_stream from an IO to a Tempfile leaves the destination IO position at the last write FAILED
Expected 0 == 42
to be truthy but was false
/Users/headius/work/jruby/spec/ruby/core/io/copy_stream_spec.rb:68:in `block in <main>'
org/jruby/RubyBasicObject.java:2572:in `instance_exec'
org/jruby/RubyArray.java:4819:in `all?'
org/jruby/RubyArray.java:1945:in `each'
org/jruby/RubyArray.java:1945:in `each'
org/jruby/RubyArray.java:1945:in `each'
/Users/headius/work/jruby/spec/ruby/core/io/copy_stream_spec.rb:100:in `<main>'
org/jruby/RubyKernel.java:1205:in `load'
org/jruby/RubyBasicObject.java:2572:in `instance_exec'
org/jruby/RubyArray.java:1945:in `each'

@headius headius added this to the JRuby 10.0.0.0 milestone Jun 19, 2024
@headius headius changed the base branch from master to 9.5-dev June 19, 2024 21:35
@headius headius merged commit cdb2312 into jruby:9.5-dev Jun 24, 2024
@headius headius deleted the fix_remaining_copy_stream_specs branch June 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 10.0.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@headius