Coderange cat for 9.3 #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This fixes jruby#247 without introducing a dependency on the new catWithCodeRange in JRuby 9.4. It does depend on a now-deprecated method cat19 that will go away in the next year or so.
b36cd2b to
5d81b71
Compare
Member
Author
|
I've reverted most of this and just call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is equivalent to the fix in #248 but using MethodHandle to call an appropriate version for the host JRuby.
It is also targeted at 1.1.x to have a compatible release of that version of jruby-rack without introducing larger changes.
See #247 (comment)