Don't overwrite user-specified webserver.properties file #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you can create a release with this in it? Thanks for fixing this, just found a need for it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though there is support for the system property
warbler.hostfor setting which host Jetty listens on, I don't want to put the onus on the user to set this when they run the JAR file in the case that I want the server to always run on a certain host (like 127.0.0.1). However, warbler was overwriting thewebserver.propertiesfile (see #181 (comment)) which made it impossible to specify a permanent change without manually extracting and replacing thewebserver.propertiesfile.This pull request simply makes it so warbler won't overwrite a user-supplied
webserver.propertiesfile.