Thanks to visit codestin.com
Credit goes to github.com

Skip to content

#552 Use URI.open instead of open #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

#552 Use URI.open instead of open #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d010e53
Refactor environment handling in web server spec
laumacirule Oct 4, 2024
ae57843
Update open-uri usage in web server
laumacirule Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/warbler/web_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def local_path
FileUtils.mkdir_p File.dirname(cached_path) #:nocov:
require 'open-uri' #:nocov:
begin
open(download_url) do |stream| #:nocov:
URI.open(download_url) do |stream| #:nocov:
File.open(cached_path, "wb") do |f| #:nocov:
while buf = stream.read(4096) #:nocov:
f << buf #:nocov:
Expand Down
8 changes: 5 additions & 3 deletions spec/warbler/web_server_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,18 @@ def self.reset_local_repository

describe Warbler::WebServer::Artifact do

@@_env = ENV.to_h

after(:all) { ENV.clear; ENV.update @@_env }
before(:all) do
@_env = ENV.to_h
end

before do
Warbler::WebServer::Artifact.reset_local_repository
end

after(:all) do
Warbler::WebServer::Artifact.reset_local_repository
ENV.clear
ENV.update @_env
end

let(:sample_artifact) do
Expand Down
Loading