Add support for Commodore Amiga #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawicz
reviewed
Dec 23, 2023
sacredbanana
commented
Dec 26, 2023
Contributor
Author
|
Bump. Are you fine with this change and want it merged in? |
hawicz
reviewed
Jun 19, 2024
hawicz
reviewed
Jun 19, 2024
Contributor
Author
|
Changes made. Please review it when you're free thanks :) |
Contributor
Author
|
Turns out libnix doesn't support duplocale() despite the symbol existing. Added a check to disable it if building for libnix. |
hawicz
reviewed
Jul 29, 2024
Contributor
Author
|
It has been a while since this PR has been looked at. I did just add one more thing to it now which is adding support for the Amiga based OS MorphOS. @hawicz |
Contributor
Author
|
@hawicz bump. does this PR look ok? I'm keen to get this merged |
Contributor
Author
|
Just fixed the merge conflict. Can I get this one reviewed please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to get json-c compiling for the Commodore Amiga. It is used in my ChatGPT client for Commodore Amiga called AmigaGPT https://github.com/sacredbanana/AmigaGPT.
Compilation for Amiga is as simple as using a Docker container. See the readme for details.