Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@benjamin-hg
Copy link

Fixes #23

@benjamin-hg
Copy link
Author

@lookfirst checks are failing -- I guess some updated dependencies are causing the issue. Would you take a look at this PR anyway?

@benjamin-hg
Copy link
Author

I was curious to measure the performance hit of my changes. As the total number on lines of code increased, I expected it to run slower. Surprisingly, it turned out to run approximately 20 % faster with my test data (~5MB JSOG file)
🎉

@lookfirst
Copy link
Member

@benjamin-hg Sorry to be so silent, both @stickfigure and I have been focused on other things.

That's great for your test data. =)

It looks like CI is failing due to outdated mocha or something. =( Maybe you can look into getting that fixed?

Can you include a test with your code? Ideally, the file that was causing the issue to begin with.

Also include the 5mb file... or even better... write a test that generates the data of any size and random structure... in memory...

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants