Update the map printer to properly print maps. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you using pp for code generation with As it's designed not for serializing Go objects but for debug, I want to keep output simple. Missing type for map/slice is intentional. But sometimes type information is convenient for debug too, so I'm okay to optionally allow that feature. Could you add some configuration variable to enable that? |
|
It should be updated now. I think I made it turned on by default, I can change that if it's not desirable. |
|
Hmm, I've misunderstood behavior for slice. This is consistent with it. So I agree that this is reasonable default. Let's introduce this and wait for feedback. |
Merged
k0kubun
added a commit
that referenced
this pull request
Mar 4, 2019
According to the GitHub search, there seem to be no user after introducing it. And by its very nature of this tool's purpose, it's very unlikely that users maintain customized configuration variables in their code. To simplify the implementation, I decided to drop this feature. See also #25 for the original discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to print maps without the type when we were looking to use this for code generation. So
would print as
Now it should print as a typed map (or typed as interface{}) e.g.