[Backport release-1.32] Merge embedded-bins ldflags in Makefile#7034
Merged
jnummelin merged 1 commit intorelease-1.32from Jan 29, 2026
Merged
[Backport release-1.32] Merge embedded-bins ldflags in Makefile#7034jnummelin merged 1 commit intorelease-1.32from
jnummelin merged 1 commit intorelease-1.32from
Conversation
Instead of passing both ldflags and ldflags_extra as build args into the Dockerfiles, do this already in the Makefile. This way, an additional build-arg is removed, and the individual builds can't forget to catenate them. Also move the quoting out of the variables into their call site. That way, it's easier to use += to append additional flags. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 56fbac1) (cherry picked from commit 12e3b14) (cherry picked from commit 5a16ac2)
jnummelin
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.32, triggered by a label in #7032.See .