Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: make Sveltos follow cluster updates #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix: make Sveltos follow cluster updates #333

merged 1 commit into from
Jun 23, 2025

Conversation

@aglarendil
Copy link
Contributor

@aglarendil aglarendil commented Jun 17, 2025 •
edited by denis-ryzhkov
Loading

closes: #331 #267

@aglarendil aglarendil force-pushed the bugfix/mcs-refresh-on-cluster-update branch from 6470f51 to 4838fda Compare June 18, 2025 17:03
@aglarendil aglarendil requested a review from AndrejsPon00 as a code owner June 18, 2025 17:03
@aglarendil aglarendil force-pushed the bugfix/mcs-refresh-on-cluster-update branch from 4838fda to 29c7439 Compare June 18, 2025 17:29
gmlexx
gmlexx requested changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@gmlexx gmlexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aglarendil please apply suggested fixes

@aglarendil aglarendil force-pushed the bugfix/mcs-refresh-on-cluster-update branch from 29c7439 to 0cacc93 Compare June 19, 2025 11:16
denis-ryzhkov
denis-ryzhkov requested changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@denis-ryzhkov denis-ryzhkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change back to Cluster with optional because we will have race condition when ClusterDeployment is updated, but we read annotations from Cluster which MAY not be updated yet.

@aglarendil aglarendil force-pushed the bugfix/mcs-refresh-on-cluster-update branch from 0cacc93 to 4f76349 Compare June 20, 2025 12:59
denis-ryzhkov
denis-ryzhkov requested changes Jun 20, 2025
View reviewed changes
@aglarendil aglarendil force-pushed the bugfix/mcs-refresh-on-cluster-update branch from 4f76349 to 3160a50 Compare June 23, 2025 11:44
denis-ryzhkov
denis-ryzhkov requested changes Jun 23, 2025
View reviewed changes
@aglarendil aglarendil requested a review from denis-ryzhkov June 23, 2025 12:42
denis-ryzhkov
denis-ryzhkov requested changes Jun 23, 2025
View reviewed changes
@aglarendil @denis-ryzhkov
fix: make Sveltos follow cluster updates
0397ebe 
otherwise kof helm charts are not upgraded on annotations update

Co-authored-by: Denis Ryzhkov <[email protected]>
@aglarendil aglarendil force-pushed the bugfix/mcs-refresh-on-cluster-update branch from 0e467da to 0397ebe Compare June 23, 2025 12:57
@denis-ryzhkov denis-ryzhkov merged commit e006d2a into k0rdent:main Jun 23, 2025
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this to Done in k0rdent Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denis-ryzhkov denis-ryzhkov denis-ryzhkov approved these changes

@AndrejsPon00 AndrejsPon00 Awaiting requested review from AndrejsPon00 AndrejsPon00 is a code owner

@gmlexx gmlexx Awaiting requested review from gmlexx gmlexx is a code owner

Assignees

No one assigned

Labels

None yet

Projects

k0rdent
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sveltos Does not Upgrade Charts on Annotations Change

3 participants

@aglarendil @denis-ryzhkov @gmlexx