chore: remove Istio code/logic (moved to separate repo) #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92dec50 to
8f42c33
Compare
fe6e0ce to
b007e84
Compare
b007e84 to
0d959d5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes all Istio-related code and logic from the kof repository, moving it to a separate repository to improve modularity and maintainability. The changes align with the goal of decoupling Istio service mesh functionality from the core KOF observability platform.
- Removes complete Istio operator integration including certificate management, remote secret handling, and multicluster setup
- Updates label values from "child" to "member" for Istio role labels to reflect the architectural change
- Replaces removed Istio functionality with new MultiClusterService templates for both regional and child clusters
Reviewed Changes
Copilot reviewed 43 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kof-operator/internal/controller/ | Removes Istio certificate manager, remote secret manager, and related controller logic |
| kof-operator/go.mod | Removes Istio and cert-manager dependencies |
| charts/kof-istio/ | Completely removes the kof-istio Helm chart and all related templates |
| charts/kof-regional/kof-child/ | Adds new MultiClusterService templates to replace removed Istio profiles |
| demo/cluster/ | Updates Istio role labels and template versions in example cluster configurations |
| docs/ | Removes Istio documentation and updates development instructions |
| Makefile | Removes Istio deployment targets and updates related scripts |
0d959d5 to
17afab3
Compare
denis-ryzhkov
requested changes
Oct 21, 2025
charts/kof-child/templates/istio-child-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
charts/kof-regional/templates/istio-regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
17afab3 to
c814155
Compare
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
denis-ryzhkov
requested changes
Oct 22, 2025
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
e740c65 to
ae88436
Compare
denis-ryzhkov
approved these changes
Oct 23, 2025
denis-ryzhkov
requested changes
Oct 24, 2025
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
denis-ryzhkov
requested changes
Oct 24, 2025
denis-ryzhkov
approved these changes
Oct 24, 2025
denis-ryzhkov
requested changes
Oct 24, 2025
denis-ryzhkov
previously approved these changes
Oct 24, 2025
denis-ryzhkov
previously approved these changes
Oct 24, 2025
a4cf33c to
537d283
Compare
denis-ryzhkov
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #534