feat: add dependsOn for kof-istio MCS to depend on Istio MCS
#616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a dependsOn field to the kof-istio MultiClusterService (MCS) resources to ensure they are created only after the Istio installation is complete. This prevents timing issues where the MCS might be created before Istio is ready.
Key Changes:
- Added
istioMcs.dependsOnconfiguration to values files for both regional and child charts - Updated MCS templates to conditionally render the
dependsOnfield when Istio is enabled
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/kof-regional/values.yaml | Adds istioMcs.dependsOn configuration with default dependency on k0rdent-istio-network-with-gateway |
| charts/kof-regional/templates/regional-multi-cluster-service.yaml | Adds conditional rendering of dependsOn field in the MCS spec when Istio is enabled |
| charts/kof-child/values.yaml | Adds istioMcs.dependsOn configuration with default dependency on k0rdent-istio-network |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Adds conditional rendering of dependsOn field in the MCS spec when Istio is enabled |
0f32f1b to
44d2d69
Compare
denis-ryzhkov
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.