chore: fix metrics port binding for kind clusters #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gmlexx
commented
Nov 11, 2025
- Fix metrics port binding for collectors access to etcd, kubelet, etc
- Fix kubelet certificate generation to include IP SAN
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes metrics port binding configuration for kind clusters to enable proper monitoring of control plane components (etcd, kubelet, controller-manager, scheduler, kube-proxy) by Prometheus collectors. It also addresses kubelet certificate generation by implementing automatic CSR approval and configuring TLS bootstrap.
Key changes:
- Introduced a new kind cluster configuration that binds all control plane component metrics endpoints to
0.0.0.0instead of localhost - Added kubelet-csr-approver Helm chart installation to handle kubelet certificate signing requests
- Updated development workflow to use the new configuration and include Docker registry authentication setup
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| config/kind-local.yaml | New kind cluster configuration that binds metrics endpoints to 0.0.0.0 for all control plane components and enables kubelet TLS bootstrap |
| config/docker/config.json | Template Docker registry authentication configuration to avoid rate limiting |
| Makefile | Added kcm-dev-apply target and updated dev-adopted-deploy to use new kind config and install kubelet-csr-approver |
| docs/dev.md | Updated development setup instructions to include kubelet-csr-approver installation |
| .github/workflows/pr_test_kof_installation.yaml | Added wait condition for kcm-controller-manager deployment availability |
| .github/workflows/pr_test_adopted_upgrade.yml | Added wait condition for kcm-controller-manager deployment availability |
denis-ryzhkov
requested changes
Nov 11, 2025
4121182 to
9afe86f
Compare
556f705 to
4718231
Compare
AndrejsPon00
approved these changes
Nov 12, 2025
denis-ryzhkov
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.