feat: automatically label kof namespace for Istio sidecar injection
#643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Purpose: Introduce automatic labeling of the kof namespace for Istio sidecar injection, unify Istio-related values under a new istio key, and add ServiceTemplate/ConfigMap resources to propagate the label to remote clusters.
- Replaces istioMcs values block with istio including an enabled flag.
- Adds kof-namespace ServiceTemplate and corresponding ConfigMap template.
- Updates MultiClusterService templates to conditionally include namespace labeling and dependsOn based on istio.enabled.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kof-regional/values.yaml | Renames istioMcs to istio and adds enabled flag and dependsOn reference. |
| charts/kof-regional/templates/regional-multi-cluster-service.yaml | Gates Istio-related logic on .Values.istio.enabled and adds kof-namespace template dependency. |
| charts/kof-mothership/values.yaml | Adds istio section with enabled flag for mothership chart. |
| charts/kof-mothership/templates/istio/svctmpl.yaml | Defines ServiceTemplate kof-namespace referencing a ConfigMap template. |
| charts/kof-mothership/templates/istio/configMap.yaml | Adds ConfigMap with namespace manifest labeling kof for Istio injection. |
| charts/kof-child/values.yaml | Renames istioMcs to istio with enabled flag and dependsOn configuration. |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Adds conditional namespace template usage and updates Istio gating; introduces new dependsOn block for kof-operators. |
ff74cbe to
f2296f3
Compare
gmlexx
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of k0rdent/istio#20