fix: Make global values compatible with new collectors #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies global values handling in Helm charts by eliminating duplication. Instead of embedding hardcoded registry override logic in each Multi-Cluster Service (MCS) template, the charts now accept a globalValues parameter that can be passed directly via --set-file or -f flags during Helm installation.
Key changes:
- Removed duplicate hardcoded global values logic from MCS templates
- Added
globalValues: {}parameter to chart values files - Simplified registry override logic to read from the new parameter
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/kof-regional/values.yaml | Added globalValues parameter to support external global values injection |
| charts/kof-regional/templates/regional-multi-cluster-service.yaml | Replaced hardcoded registry override logic with simpler logic using globalValues parameter |
| charts/kof-child/values.yaml | Added globalValues parameter to support external global values injection |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Replaced hardcoded registry override logic with simpler logic using globalValues parameter |
charts/kof-regional/templates/regional-multi-cluster-service.yaml
Outdated
Show resolved
Hide resolved
denis-ryzhkov
added a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-f global-values.yamlon direct helm install,--set-file globalValues=global-values.yamlon helm install via MCS-es.