Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix spegel logging and startup sequence #12796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

Fix spegel logging and startup sequence #12796

merged 1 commit into from
Aug 25, 2025

Conversation

@brandond
Copy link
Member

@brandond brandond commented Aug 22, 2025 •
edited
Loading

Proposed Changes

  • Properly wrap logrus as a logr log sink, instead of just passing in the logrus io.Writer.
  • Start spegel stats image tracking after containerd is up, so it doesn't try to poke at containerd before it is running.

Types of Changes

bugfix/quality of life

Verification

Check logs:

  • node that spegel image state update does not run until after containerd is started
  • note that logs from spegel now have the correct log level, say logger=spegel, and do not have a double timestamp:
ERRO[0002] could not get bootstrap addresses             error="runtime core not ready, cannot get addresses without server and token, p2p peer not ready" logger=spegel/p2p
INFO[0002] starting p2p router                           id=/ip4/172.17.0.4/tcp/5001/p2p/QmZMCP1QM5uBNEAic3XEyJhTErLuyQNUz4663jvB6WULNQ logger=spegel/p2p
INFO[0002] skipping bootstrap peer that is same as host  logger=spegel/p2p
INFO[0002] no bootstrap nodes found                      logger=spegel/p2p
INFO[0005] running scheduled image state update          logger=spegel

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner August 22, 2025 17:39
@brandond brandond mentioned this pull request Aug 22, 2025
Closed
dereknola
dereknola previously approved these changes Aug 22, 2025
View reviewed changes
@brandond brandond force-pushed the fix-spegel-logging branch from 820ef6e to d0d4581 Compare August 22, 2025 18:05
@codecov
Copy link

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.44%. Comparing base (e7dd3b7) to head (d0d4581).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/logger/logger.go 0.00% 40 Missing ⚠️
pkg/spegel/spegel.go 0.00% 6 Missing ⚠️
pkg/agent/run.go 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e7dd3b7) and HEAD (d0d4581). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e7dd3b7) HEAD (d0d4581)
e2etests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #12796       +/-   ##
===========================================
- Coverage   40.68%   20.44%   -20.25%     
===========================================
  Files         184      182        -2     
  Lines       18872    18848       -24     
===========================================
- Hits         7679     3854     -3825     
- Misses      10015    14558     +4543     
+ Partials     1178      436      -742
Flag Coverage Δ
e2etests ?
unittests 20.44% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brandond brandond requested review from a team and dereknola August 22, 2025 18:23
@brandond brandond merged commit 356bd5d into k3s-io:master Aug 25, 2025
54 checks passed
This was referenced Sep 5, 2025
Closed
Merged
Merged
Merged
@cguertin14 cguertin14 mentioned this pull request Sep 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelbuil manuelbuil manuelbuil approved these changes

@vitorsavian vitorsavian vitorsavian approved these changes

@dereknola dereknola Awaiting requested review from dereknola

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandond @dereknola @manuelbuil @vitorsavian