Retry CRD creation in case of conflict #12814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7df707b to
ab80030
Compare
ab80030 to
0ea8c76
Compare
Also cleans up some of the server.Context factory creation stuff to eliminate unused code paths and avoid registering the Helm controller when helm is disabled. As of fe465cc we no longer call NewContext outside pkg/server, so the isServer bool flag to use the supervisor kubeconfig and create an event recorder is unnecessary. Signed-off-by: Brad Davidson <[email protected]>
0ea8c76 to
a9fec4c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12814 +/- ##
===========================================
- Coverage 40.66% 20.43% -20.24%
===========================================
Files 185 182 -3
Lines 18916 18857 -59
===========================================
- Hits 7693 3854 -3839
- Misses 10049 14567 +4518
+ Partials 1174 436 -738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dereknola
approved these changes
Aug 26, 2025
vitorsavian
approved these changes
Aug 26, 2025
This was referenced Sep 5, 2025
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Retry CRD creation in case of conflict
Also cleans up some of the
server.Contextfactory creation stuff to eliminate unused code paths and avoid registering the Helm controller when helm is disabled.As of fe465cc we no longer call
NewContextoutsidepkg/server, so theisServerbool flag to use the supervisor kubeconfig and create an event recorder is unnecessary.Types of Changes
bugfix
tech debt
Verification
See linked issue - this is difficult to reproduce due to tight timing; multiple control-plane nodes need to be at the exact same spot in the startup sequence at the exact same time.
Testing
Linked Issues
User-Facing Change
Further Comments