Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

KTOR-9267 Curl: Handle chunked websocket frames#5355

Merged
osipxd merged 2 commits intorelease/3.xfrom
osipxd/curl-chunked-frames
Feb 13, 2026
Merged

KTOR-9267 Curl: Handle chunked websocket frames#5355
osipxd merged 2 commits intorelease/3.xfrom
osipxd/curl-chunked-frames

Conversation

@osipxd
Copy link
Member

@osipxd osipxd commented Feb 5, 2026

Subsystem
kotlin-client-curl

Motivation
KTOR-9267 Curl: Incorrect WebSockets frame fragmentation

Solution
Read meta.offset and meta.bytesleft to determine chunked frames. Collect frame data into a buffer and send at once.

@osipxd osipxd self-assigned this Feb 5, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch osipxd/curl-chunked-frames

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@osipxd osipxd marked this pull request as draft February 5, 2026 19:08
@osipxd osipxd marked this pull request as ready for review February 6, 2026 10:45
@osipxd osipxd requested a review from zibet27 February 6, 2026 10:46
zibet27
zibet27 reviewed Feb 9, 2026
View reviewed changes
Copy link
Collaborator

@zibet27 zibet27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but a new test is failing on the CI
There should also be a segfault, because it has no stacktrace

bjhham
bjhham requested changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you implement handling for WebSocketSession.maxFrameSize so that we have consistent handling / some safety against massive frames?

@osipxd osipxd force-pushed the osipxd/curl-chunked-frames branch from 735486c to ddde8b4 Compare February 11, 2026 22:27
@osipxd
Copy link
Member Author

osipxd commented Feb 11, 2026

@bjhham, I've implemented a fix but I'd like to open another PR for it. Could you approve this one?
Here is an issue to track: KTOR-9327 Curl: Support WebSockets maxFrameSize option

@osipxd osipxd force-pushed the osipxd/curl-chunked-frames branch from fec9286 to c415f5c Compare February 12, 2026 16:48
@osipxd osipxd enabled auto-merge (squash) February 13, 2026 08:50
@osipxd osipxd merged commit 78641d1 into release/3.x Feb 13, 2026
15 of 17 checks passed
@osipxd osipxd deleted the osipxd/curl-chunked-frames branch February 13, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zibet27 zibet27 zibet27 left review comments

@bjhham bjhham bjhham approved these changes

Assignees

@osipxd osipxd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@osipxd @zibet27 @bjhham