build: update to bazel v6.5.0 and rules_oci #13111
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
c6fa5b7 to
16710e2
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
|
/test pull-kubevirt-build-s390x pull-kubevirt-build-arm64 |
16710e2 to
425c035
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
425c035 to
6f1a3bd
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
6f1a3bd to
02e9451
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
02e9451 to
25cb8b4
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute pull-kubevirt-build-arm64 pull-kubevirt-build-s390x |
25cb8b4 to
ce5ef0e
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
ce5ef0e to
6874be7
Compare
|
/test pull-kubevirt-build pull-kubevirt-generate pull-kubevirt-unit-test pull-kubevirt-manifests pull-kubevirt-e2e-k8s-1.31-sig-compute |
6874be7 to
40bb9d7
Compare
Includes libguestfs, pr-helper, cloudinit sidecar, network-passt-binding, network-slirp-binding, smbios, disk-mutation, disk-images-provider, vm-killer and winrmcli Signed-off-by: Brian Carey <[email protected]>
738e117 to
8e6bf28
Compare
Signed-off-by: Brian Carey <[email protected]>
Images include - virt-api, virt-controller, virt-handler, virt-launcher, virt-operator, virt-exportserver and virt-exportproxy Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
…_push the variables passed through `bazel run --define` no longer work with oci_push Remove these and switch the providing repository and tag details as part of running the push target. Signed-off-by: Brian Carey <[email protected]>
container_image Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
A release that is based on https://github.com/brianmcarey/bazeldnf/tree/test-xattrs which includes fixes for the xattrs issues Also update newly introduced images like synchronization-controller to use rules_oci Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
8e6bf28 to
6952a5b
Compare
dhiller
left a comment
There was a problem hiding this comment.
Looks great, thank you @brianmcarey !
🎉 💯 🥇
|
Required labels detected, running phase 2 presubmits: |
|
@brianmcarey: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
|
@brianmcarey hi This PR breaks the HCO nightly test, but this is just an indication for bigger issue. These two images are used by HCO, when generating the CSV. They can't be found now:
|
I have a PR up for quay.io/kubevirt/virt-synchronization-controller - #15771 |
What this PR does
Update to bazel v6.5.0[1]
Attempting to build with rules_docker led to issues and as it has been deprecated - we should start using rules_oci[2]
[1] https://github.com/bazelbuild/bazel/releases/tag/6.5.0
[2] https://github.com/bazel-contrib/rules_oci
Fixes #10983
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
/cc @xpivarc @dhiller
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note