Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add supplementalPool to the description of the ioThreadsPolicy possible values #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubevirt-bot merged 1 commit into from
Apr 2, 2025
Merged

Add supplementalPool to the description of the ioThreadsPolicy possible values #14405

kubevirt-bot merged 1 commit into from
Apr 2, 2025

Conversation

@jpeimer
Copy link
Contributor

@jpeimer jpeimer commented Apr 2, 2025

What this PR does

Follow up for the PR that introduces the actual functionality: #13110

Before this PR:

$ oc explain vm.spec.template.spec.domain.ioThreadsPolicy
...
DESCRIPTION:
    ...
    One of: shared, auto

After this PR:

$ oc explain vm.spec.template.spec.domain.ioThreadsPolicy
...
DESCRIPTION:
    ...
    One of: shared, auto, supplementalPool

Fixes #

Release note

supplementalPool added to the description of the ioThreadsPolicy possible values

@jpeimer
Add supplementalPool option to ioThreadsPolicy description
4987267 
Follow up for the PR that introduces the actual functionality:
kubevirt#13110

Signed-off-by: Jenia Peimer <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 2, 2025
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 2, 2025

Hi @jpeimer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added area/api-server sig/api Denotes an issue or PR that relates to changes in api. labels Apr 2, 2025
@alicefr
Copy link
Member

alicefr commented Apr 2, 2025

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@kubevirt-commenter-bot
Copy link

kubevirt-commenter-bot commented Apr 2, 2025

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

@jpeimer
Copy link
Contributor Author

jpeimer commented Apr 2, 2025

/cc @akalenyu

@kubevirt-bot kubevirt-bot requested a review from akalenyu April 2, 2025 13:59
@akalenyu
Copy link
Contributor

akalenyu commented Apr 2, 2025

Yeah this is a different flake that's been coming up unrelated to the nfs stuff but still frequent cc @brianmcarey

@kubevirt-bot kubevirt-bot merged commit a22c445 into kubevirt:main Apr 2, 2025
39 checks passed
@jpeimer
Copy link
Contributor Author

jpeimer commented Apr 3, 2025

/cherry-pick release-1.5

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 3, 2025

@jpeimer: only kubevirt org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alicefr
Copy link
Member

alicefr commented Apr 4, 2025

/cherry-pick release-1.5

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 4, 2025

@alicefr: new pull request created: #14421

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Apr 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iholder101 iholder101 Awaiting requested review from iholder101

@mhenriks mhenriks Awaiting requested review from mhenriks

@akalenyu akalenyu Awaiting requested review from akalenyu

Assignees

@alicefr alicefr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api-server dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes an issue or PR that relates to changes in api. size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpeimer @kubevirt-bot @alicefr @kubevirt-commenter-bot @akalenyu