Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump kubevirtci, un-quarantine NFS tests and add missing NFS env var #14428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kubevirt-bot merged 3 commits into from
Apr 8, 2025
Merged

Bump kubevirtci, un-quarantine NFS tests and add missing NFS env var #14428

kubevirt-bot merged 3 commits into from
Apr 8, 2025

Conversation

@jean-edouard
Copy link
Contributor

@jean-edouard jean-edouard commented Apr 6, 2025

What this PR does

This PR duplicates #14401 and adds the necessary bits from #14411

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

To use nfs-csi, the env variable KUBEVIRT_NFS_DIR has to be set to a location on the host for NFS data

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. size/M labels Apr 6, 2025
@jean-edouard jean-edouard mentioned this pull request Apr 6, 2025
Merged
@dosubot dosubot bot added the sig/testing label Apr 6, 2025
@jean-edouard jean-edouard force-pushed the bumpandfixnfs branch 2 times, most recently from d7b0def to 3cdeb8b Compare April 6, 2025 23:20
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 6, 2025
@nirdothan
Copy link
Member

nirdothan commented Apr 7, 2025

/retest-required

@brianmcarey
Copy link
Member

brianmcarey commented Apr 7, 2025

@jean-edouard - we still need to wait for kubevirt/kubevirtci#1416 to resolve the problem of ceph not deploying and then this should be good to go.

jean-edouard and others added 3 commits April 7, 2025 16:31
@jean-edouard
Revert "migrations,e2e: Quarantine flaky compute-migrations tests"
7992ea9 
This reverts commit bc53fd7.

Signed-off-by: Jed Lejosne <[email protected]>
@jean-edouard
automation: define KUBEVIRT_NFS_DIR
c3dc2a5 
Signed-off-by: Jed Lejosne <[email protected]>
@kubevirt-bot @jean-edouard
Bump kubevirtci
c91f6dc 
[2880e25 rookceph: Add endpoint slices to default rook ceph serviceaccount](kubevirt/kubevirtci#1416)
[4778243 Remove in-cluster nfs server in favor of external one](kubevirt/kubevirtci#1415)
[9e66f8d Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1414)
[88c9b51 cluster-prv, gocli, istio: Bump istio to 1.24.4](kubevirt/kubevirtci#1411)
[29ba6f0 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1409)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Signed-off-by: Jed Lejosne <[email protected]>
@jean-edouard
Copy link
Contributor Author

jean-edouard commented Apr 7, 2025

/retest
/cc @dhiller

@kubevirt-bot kubevirt-bot requested a review from dhiller April 7, 2025 23:45
@jean-edouard jean-edouard changed the title Bump kubevirtci, un-quarantine NFS test and add missing NFS env var Bump kubevirtci, un-quarantine NFS tests and add missing NFS env var Apr 8, 2025
brianmcarey
brianmcarey reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @jean-edouard !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2025
dhiller
dhiller approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you @jean-edouard 🎉 💯

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@kubevirt-commenter-bot
Copy link

kubevirt-commenter-bot commented Apr 8, 2025

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

@nirdothan
Copy link
Member

nirdothan commented Apr 8, 2025

/test pull-kubevirt-e2e-k8s-1.31-sig-storage

@brianmcarey
Copy link
Member

brianmcarey commented Apr 8, 2025

/override pull-kubevirt-e2e-k8s-1.32-sig-storage

It has already passed against this PR and the failed run hit a flake.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 8, 2025

@brianmcarey: Overrode contexts on behalf of brianmcarey: pull-kubevirt-e2e-k8s-1.32-sig-storage

Details

In response to this:

/override pull-kubevirt-e2e-k8s-1.32-sig-storage

It has already passed against this PR and the failed run hit a flake.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit 15a9d6f into kubevirt:main Apr 8, 2025
38 checks passed
This was referenced Apr 8, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhiller dhiller dhiller approved these changes

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@enp0s3 enp0s3 Awaiting requested review from enp0s3

@xpivarc xpivarc Awaiting requested review from xpivarc

+1 more reviewer

@brianmcarey brianmcarey brianmcarey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dhiller dhiller

@brianmcarey brianmcarey

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/buildsystem Denotes an issue or PR that relates to changes in the build system. sig/testing size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jean-edouard @nirdothan @brianmcarey @kubevirt-bot @kubevirt-commenter-bot @dhiller